Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI with clippy fixes, update some dependencies #116

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jan 28, 2025

Description of change

Run cargo clippy and follow suggestions + fmt

@nyurik nyurik requested a review from orhun as a code owner January 28, 2025 06:32
@nyurik nyurik changed the title Fix CI by applying all clippy changes Fix CI with clippy fixes, update some dependencies Jan 28, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.30%. Comparing base (b3c5487) to head (9ae6f87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #116   +/-   ##
=====================================
  Coverage   3.30%   3.30%           
=====================================
  Files         19      19           
  Lines       2426    2426           
=====================================
  Hits          80      80           
  Misses      2346    2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'd appreciate if you can also update the Ratatui dependency in another PR :)

@orhun orhun merged commit 0f38dc9 into orhun:main Jan 29, 2025
26 of 28 checks passed
@nyurik nyurik deleted the fix-ci branch January 29, 2025 18:36
@nyurik
Copy link
Contributor Author

nyurik commented Jan 29, 2025

@orhun i tried, but it gave me some trouble as a lot of code had to be updated

@orhun
Copy link
Owner

orhun commented Jan 29, 2025

no worries, I'll do it before the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants