Draft: Export and import app settings to/from note #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when parsing preference values.
amberin
requested review from
alensiljak,
stefan2904,
colonelpanic8,
alexanderkunz,
bemyak,
cbkerr and
philipp-reinhardt
amberin
changed the title
alensiljak
previously approved these changes
Feb 17, 2025
Throw an error when this happens, instead of silently pretending that there was only one match. (When using property ID's to store app settings, the previous behavior would be dangerous. We would risk overwriting the wrong note with user settings data.)
…chosen note The UI code has mostly been copied from ui.refile. If I were better at Android, I would refactor to reduce the amount of duplicated code. But this is easier, and I doubt it will create total chaos.
amberin
force-pushed
the
128-export-settings-tidy
branch
from
28626f8 to
6f16e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for how to solve #128, but it's just an early draft to get feedback on the general thinking.
I chose to also include saved searches, even though there is already another export/import feature for those. Because, well, why wouldn't you want them included?
I'm thinking a few tests would be good to ensure that
The UI code was mostly copied from the "refile" dialog.
Only notes without children are eligible as export/import targets.
This is what it currently looks like: