Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect fix #413

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Reconnect fix #413

wants to merge 37 commits into from

Commits on Jul 12, 2022

  1. Recover mod after disconnect

    Tested (once so far) and it worked. Keeping as draft until further test runs.
    TheGrayAlien committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    88a03d1 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    wrong gamestate name in method
    TheGrayAlien committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    dd7f525 View commit details
    Browse the repository at this point in the history
  3. Oops!

    Totally forgot to load Post with the Pre.
    TheGrayAlien committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0f471f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Fix multiple players using HR

    This should prevent a second HR using player from activating their ruleset if they gain host.
    TheGrayAlien committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3cc3077 View commit details
    Browse the repository at this point in the history
  2. Notify on ruleset re-activation

    Notify Host with a shorter timed welcome message when ruleset is restored.
    TheGrayAlien committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f44951e View commit details
    Browse the repository at this point in the history
  3. Clarifying log reports

    N/A
    TheGrayAlien committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6cfe995 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Fixed freeze

    Level sequence already loads properly without redefining it. Freezes game otherwise.
    TheGrayAlien committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    26a88c8 View commit details
    Browse the repository at this point in the history
  2. Skip this rule when loading OnPreGameCreated

    Prevents error message when loading ruleset after reconnect.
    TheGrayAlien committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    f4eb92f View commit details
    Browse the repository at this point in the history
  3. Fix LevelSequence loading

    Fix level sequence not loading on new games since last update.
    TheGrayAlien committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4ad8190 View commit details
    Browse the repository at this point in the history
  4. Piece adjustments must remain loaded

    Piece adjustments get lost if unloaded so keep them activated for possible reconnect.
    Don't reload them if reconnect as they are already still loaded.
    If it's not your game and you become host it will deactivate ALL rules.
    TheGrayAlien committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    6da4440 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Fix Play Again

    Set gameId when hitting play again in case of disconnect in next match
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    f84ab00 View commit details
    Browse the repository at this point in the history
  2. Fix missing variable set

    Some rules were prevented from loading when new room initialized after a disconnect.
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    429b6a4 View commit details
    Browse the repository at this point in the history
  3. Detect manual disconnects

    Prevent manual disconnects from being seen as forced disconnects.
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    084b0a9 View commit details
    Browse the repository at this point in the history
  4. Detect manual disconnects v2

    Only try to reconnect mod on unintentional disconnects
    User CoreMod logger for consistency
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    87c99ad View commit details
    Browse the repository at this point in the history
  5. Set variable at game over

    Just in case
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    4687110 View commit details
    Browse the repository at this point in the history
  6. Update functionality

    Fully deactivate ruleset if joining a different game
    Only report disconnects and set _isReconnect if you are hosting and ruleset is active
    TheGrayAlien committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    1389e91 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Implemented Type

    IDisableOnReconnect Type prevents unload/load of rule on disconnect
    Added Type to (so far) discovered problematic rules
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    32497bc View commit details
    Browse the repository at this point in the history
  2. Fix pregame and postgame loading

    Whoops!
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    15f3ac8 View commit details
    Browse the repository at this point in the history
  3. Fix OnPostGameCreated

    Skipping (might) not (be) necessary? Will test.
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ef194ae View commit details
    Browse the repository at this point in the history
  4. Trying again...

    Try skip deactivation and reactivation of non-working rules. Untested.
    PieceConfig wasn't working so added to IDisableOnReconnect list
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    585d25a View commit details
    Browse the repository at this point in the history
  5. Cleanups

    n/a
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    948ccb6 View commit details
    Browse the repository at this point in the history
  6. Fix problematic GameHub.GameID

    Use original game creation room code as reference instead.
    TheGrayAlien committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c5b4dee View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Fix active ruleset check

    Let ruleset load when active if reconnect possible
    Don't try to reconnect if quitting when game is ended
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    469cca5 View commit details
    Browse the repository at this point in the history
  2. Fix summary for new Type

    n/a
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7fba3a5 View commit details
    Browse the repository at this point in the history
  3. Keep up to date with main

    n/a
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    20b5b36 View commit details
    Browse the repository at this point in the history
  4. Remove previous commit

    Variable prevented reconnect after finished game and was unnecessary.
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    90a3bd1 View commit details
    Browse the repository at this point in the history
  5. Unnecessary - already in main

    n/a
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    cd89eab View commit details
    Browse the repository at this point in the history
  6. Disable if Host chooses not to reconnect

    Untested
    TheGrayAlien committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    e1bbbd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Added new Type to another rule

    This rule also doesn't work when new players enter if not held in memory after reconnect.
    TheGrayAlien committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    887ddfd View commit details
    Browse the repository at this point in the history
  2. Added DeactivateReconnect function

    Deactivates only reconnection rules as needed.
    TheGrayAlien committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    b3ea715 View commit details
    Browse the repository at this point in the history
  3. Proper deactivation fix

    Only deactivate active reconnection rules when manually disconnecting.
    TheGrayAlien committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7cd6392 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Code cleanup

    Changes some log warnings to messages and vice versa
    Consolidate some code
    TheGrayAlien committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    cd53eb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7df968c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Configuration menu
    Copy the full SHA
    3b20fe6 View commit details
    Browse the repository at this point in the history
  2. Allow ruleset re-selection

    Fixes not being able to change rulesets after selecting and playing one
    TheGrayAlien committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    a508d4e View commit details
    Browse the repository at this point in the history
  3. Fixes for latest updates to main

    n/a
    TheGrayAlien committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    bdc38c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d394d95 View commit details
    Browse the repository at this point in the history