Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes "Hide from Main View" options match the behavior described in the docs. #68

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CheesecakeCG
Copy link

This would break compatibility with materials using current version of the shader.

The "Hide from Main View" options seem to just hide the geometry completely (for cameras and mirrors too) rather than hiding only in the main view. The docs & property labels imply these work the same way as the other 4 options for just the mirror or camera views.

@orels1
Copy link
Owner

orels1 commented Jun 1, 2024

Hey, thanks for the PR. That was definitely not intentional. I was under the impression that isVR() check I had only pass for main view

@CheesecakeCG
Copy link
Author

I didn't test in VR before I submitted this (and forgot to hit send when I wrote this reply a week ago 😅), the issue still happens in VR. :/
This does fix it in desktop though.

Was this working in Unity 2019 or 2022.3.6f1? Maybe something's broken with the VR check?

@CheesecakeCG CheesecakeCG marked this pull request as draft June 15, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants