Skip to content

Commit

Permalink
Merge branch '1.x' into 2.x
Browse files Browse the repository at this point in the history
  • Loading branch information
crynobone committed Jul 21, 2023
2 parents 0354868 + 7c6a48d commit f71d0bd
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG-1.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

This changelog references the relevant changes (bug and security fixes) done to `orchestra/dusk-updater`.

## 1.6.2

Released: 2023-07-21

### Fixes

* Fixes `mac_arm64` and remove `win64` platform name.

## 1.6.1

Released: 2023-07-21
Expand Down
4 changes: 1 addition & 3 deletions src/Command.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ protected function resolveDownloadUrl(string $version, string $slug): string
if (version_compare($version, '113.0', '<')) {
if ($slug == 'mac_arm64' && version_compare($version, '106.0.5249', '<')) {
$slug == 'mac64_m1';
} elseif ($slug === 'win64') {
$slug = 'win';
}

return sprintf('https://chromedriver.storage.googleapis.com/%s/chromedriver_%s.zip', $version, $slug);
Expand All @@ -109,7 +107,7 @@ protected function resolveDownloadUrl(string $version, string $slug): string

$slugs = [
'mac64' => 'mac-x64',
'mac_arm64' => 'mac-x64',
'mac_arm64' => 'mac-arm64',
];

$slug = $slugs[$slug] ?? $slug;
Expand Down
2 changes: 1 addition & 1 deletion src/OperatingSystem.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class OperatingSystem
public static function id(): string
{
if (static::onWindows()) {
return \defined('PHP_INT_SIZE') && PHP_INT_SIZE === 8 ? 'win64' : 'win';
return 'win';
} elseif (static::onMac()) {
return static::macArchitectureId();
}
Expand Down

0 comments on commit f71d0bd

Please sign in to comment.