-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds Sunset language and offramp for sub/showcase #60
Conversation
@Christian-MK thanks for this first approach. First review the words look pretty good but I'd like to circle back. From a maintenance perspective, I'd like to consider:
For subsidized + sponsored -- we should list the feeds manually, even if we have no sponsored feeds we can just make that clear. For subsidized feeds we should just state what subsidized means, and what it means to sunset those, i.e. the protocol. I would avoid listing them, and I would make it clear how to identify them on the explorer, and describe the protocol. Suggested structure using more of a plain-language approach:
E.g.
I think we're missing clearer delineation on the explorer -- I thought we were showing that feeds were sponsored/subsidized. It looks like we're 3-6 weeks away from being able to sunset current feeds with the protocol likely:
|
Thanks for the review @ross-spencer ! I have reorganized the sections accordingly and would love a final read through. |
docs/orcfax-feeds/feed-overview.md
Outdated
feeds will be offered in this capacity; Orcfax may change or remove support for | ||
showcase feeds at its discretion and may do so without notice. Integrators who | ||
would like to take advantage of these feeds or are interested in learning more | ||
about our services should contact us via [Discord][discord] or <[email protected]>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This email link means docs wont build locally. It can be:
[[email protected]](mailto:[email protected]).
Or needs to use the reference style formerly on this page:
[email]: mailto:[email protected]
docs/orcfax-feeds/feed-overview.md
Outdated
Orcfax is currently offering the following DEX showcase feeds: | ||
|
||
| Feed name | Start Date | End date | | ||
| --------- | -------------------------- | -------- | | ||
| ADA-DJED | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| ADA-iUSD | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| ADA-USDM | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| AGIX-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| BOOK-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| BTN-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| CERRA-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| COPI-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| HOSKY-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| HUNT-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| INDY-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| LENFI-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| LQ-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| MIN-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| SHEN-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| SNEK-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| WMTx-ADA | Sep 12th 2024 17:01:24 UTC | TBA | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have this open https://github.com/orcfax/issues/issues/208 and I opened this https://github.com/orcfax/issues/issues/229.
In preparation for either, I would remove showcase feeds here entirely.
The status feed is one route we have to announce a sunset -- todo -- check with Gabriel how we might run that protocol.
We could consider some text such as:
Feeds not currently listed as subsidized or sponsored are showcase.
This ensures that:
- long-running feeds receive maintenance on these docs, and maintenance is a light-lift.
- short-running feeds are not a maintenance burden.
I might not even explain that this will be visible on the explorer right now, relying instead on the strength of our communications until the attached issues are addressed.
docs/orcfax-feeds/feed-overview.md
Outdated
|
||
The price values published by these feeds are derived entirely from centralized | ||
exchange ([CEX][cex-1]) data. | ||
For CEX based feeds, fiat currency names follow ISO [4217][cex-2] and ordering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CEX based feeds, fiat currency names follow ISO [4217][cex-2] and ordering | |
For CEX based feeds, fiat currency names follow [ISO 4217][cex-2] and ordering |
docs/orcfax-feeds/feed-overview.md
Outdated
Fiat currency names follow ISO [4217][cex-2] and Ordering follows [forex][cex-3] | ||
convention where applicable. In other cases, such as for crypto base currencies, | ||
ordering defers to how the pairs appear on CEXes. | ||
For DEX based feeds, ordering defers to how pairs appear on DEXes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two sentences are difficult to parse while reading, I wonder if we can simply say:
In all other cases, ordering defers to how pairs appear on the centralized or decentralized exchanges (CEX/DEX).
I see you've linked to the glossary, an explicit info box might help readers and promote it nicely:
INFO: The Glossary provides more information on the terminology and standard adopted by Orcfax.
decentralized exchange ([DEX][dex-1]) data. | ||
| Feed name | Start Date | End date | | ||
| --------- | -------------------------- | -------- | | ||
| FACT-ADA | Sep 12th 2024 17:01:24 UTC | TBA | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be one table.
docs/orcfax-feeds/feed-overview.md
Outdated
risk; Orcfax still reserves the right to adjust or remove support for these | ||
feeds as business needs dictate. However, any change to service relating to | ||
subsidized feeds will be announced three months in advance in order to provide | ||
integrators with adequate forewarning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part:
any change to service relating to
subsidized feeds will be announced three months in advance in order to provide
integrators with adequate forewarning.
Ideally will be a the top of this section using plain-language.
E.g.
Changes to service relating to subsidized feeds will be announced three months in advance in order to provide integrators with adequate forewarning.
Alternatively (my preference), the language more terse:
Orcfax has agreed to cover the cost of their support of subsidized feeds enabling them to be used in production. Changes to services relating to subsidized feeds will be announced three months in advance to provide integrators with adequate forewarning.
docs/orcfax-feeds/feed-overview.md
Outdated
facilitating its publication, projects which are not participating in the feed's | ||
sponsorship and yet utilize the on-chain data should do so at their own risk; | ||
feed sponsors may change or remove feed support at their own discretion and are | ||
not required to communicate these intentions to external parties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest:
Sponsored feeds are those supported by an integrator through a subscription, e.g. heartbeat or deviation. Projects utilizing sponsored feeds, but are not paying for the feed, should do so at their own risk. Sponsors may change or remove support at their own discretion.
docs/orcfax-feeds/feed-overview.md
Outdated
their feeds. | ||
|
||
Integrators will be given a two week window to come current on balances owing, | ||
afterwhich unpaid feeds will have publication suspended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest:
Orcfax will remove support for sponsored feeds 2-weeks after non-payment where there are no subscribed integrators.
docs/orcfax-feeds/feed-overview.md
Outdated
|
||
## Showcase feeds | ||
|
||
In order to demonstrate the kinds of feeds which integrators can utilize in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to demonstrate the kinds of feeds which integrators can utilize in | |
To demonstrate the kinds of feeds which integrators can utilize in |
docs/orcfax-feeds/feed-overview.md
Outdated
|
||
In order to demonstrate the kinds of feeds which integrators can utilize in | ||
their dApps, Orcfax will periodically select feeds from its catalogue and | ||
highlight them through publication as showcase feeds. Orcfax sets no minimum or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a newline:
highlight them through publication as showcase feeds. Orcfax sets no minimum or | |
highlight them through publication as showcase feeds. | |
Orcfax sets no minimum or |
docs/orcfax-feeds/feed-overview.md
Outdated
Unless otherwise specified, Orcfax makes no guarantees as to how long showcase | ||
feeds will be offered in this capacity; Orcfax may change or remove support for | ||
showcase feeds at its discretion and may do so without notice. Integrators who | ||
would like to take advantage of these feeds or are interested in learning more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing:
Unless otherwise specified, Orcfax makes no guarantees as to how long showcase
feeds will be offered in this capacity;
And just start with:
Orcfax may change or remove support for showcase feeds at its discretion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orcfax may change or remove support for showcase feeds at its discretion
have changed to
Orcfax may change or remove support for showcase feeds at its discretion and may
do so without notice.
This work? I think stating that we can do so without notice is helpful
| SNEK-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
| WMTx-ADA | Sep 12th 2024 17:01:24 UTC | TBA | | ||
|
||
:::warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
### Sunsetting showcase feeds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to ## Removal of feed support
? If so no, I had meant for this to be this way. I felt that it was important to state that there could be an instance where Orcfax would remove token support-- not simply ending its showcase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize, this feels like a more substantial inprint of style than I'd normally prefer.
My focus in the comments is on:
- Maintenance (information that changes in short-order and is delivered more frequently should be delivered through fast moving channels; allowing us to focus on information with a longer life-cycle here)
- Getting to the information as quickly as possible. I've described it as more terse language but I think it might be more active voice (versus passive voice).
If there's anything you are able to cherry-pick from my suggestions then I feel it will help.
Two things I wonder if it would make sense to be clearer on:
- communicating the sunset of a feed -- in all cases, we will communicate through our status/social channels about the sunsetting of a feed (probably repeating some of the language hee0
- Terms of service: https://docs.orcfax.io/terms-of-service <-- do we want to draw attention to the terms of service? (i am torn, because this page is not a legal page and don't want to pretend it is, but the terms of service are important too)
Nb,
Will add this to the Trello to discuss later. |
Gabrriel has implemented the filter feature here! https://github.com/orcfax/issues/issues/229#issuecomment-2683394906 |
@ross-spencer I have added your edits! All good to merge? |
@gchartier after our last call re prettier and formatting my pushes are going through fine but I keep recieving the following emails after each
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, and approving so you're not held up merging.
I only have one last query which can be addressed now or maybe later, but under the section "removing feed support"
In the absence of a subscription to support a feed's publication or business decisions which may incentivize subsidization, Orcfax may suspend or remove technical support for feeds at its discretion.
Unless otherwise required (e.g. in the case of subsidized feeds) Orcfax may remove support for such a feed without notice.
maybe this just needs removing? "or business decisions which may incentivize subsidization, " <-- it doesn't feel very clear.
Suggest:
Unless a feed is supported, i.e. sponsored and paid for by a third-party, or subsidized through Orcfax, we may suspend or remove technical support for sponsored feeds at our own discretion.
Once merged, the text here should help Peter's more legalese text for any user agreements; and maybe vice versa.
changed per your suggestion |
No description provided.