Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reverse_proxy_plug from 2.3.0 to 2.4.0 in /server #348

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2024

Bumps reverse_proxy_plug from 2.3.0 to 2.4.0.

Release notes

Sourced from reverse_proxy_plug's releases.

v2.4.0

New features

  • optional upstream header transform function using the :normalize_headers option (#180)

Fixes

  • refactor stream handling to optional callback per adapter (#186)
  • migrate to Hammox (#181, #183, #184)
  • dependency updates (#185)
  • misc refactoring (#188)

v2.3.1

Fixes

  • rewrite read_body to carry conn forward (#177)
    • Note that this will, for the time being, result in request bodies which may have previously been streamed in certain scenarios now being read entirely into memory before being streamed upstream. tallarium/reverse_proxy_plug#176 tracks the work to restore this behaviour
  • add test coverage reporting to the CI run (#178)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [reverse_proxy_plug](https://github.com/tallarium/reverse_proxy_plug) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/tallarium/reverse_proxy_plug/releases)
- [Commits](tallarium/reverse_proxy_plug@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: reverse_proxy_plug
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from skanderm as a code owner February 26, 2024 13:31
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Feb 26, 2024
@paulcretu paulcretu temporarily deployed to orcasite-pr-348 February 26, 2024 13:35 Inactive
@skanderm
Copy link
Contributor

Interesting, looks like our CI checks have caught something! I can deal with this. Logs from heroku:

2024-02-27T20:56:16.663176+00:00 app[web.1]: 20:56:16.659 [error] #PID<0.1250.0> running OrcasiteWeb.Endpoint (connection #PID<0.1249.0>, stream id 1) terminated
2024-02-27T20:56:16.663177+00:00 app[web.1]: Server: orcasite-pr-348.herokuapp.com:80 (http)
2024-02-27T20:56:16.663180+00:00 app[web.1]: Request: GET /
2024-02-27T20:56:16.663181+00:00 app[web.1]: ** (exit) an exception was raised:
2024-02-27T20:56:16.663181+00:00 app[web.1]: ** (ArgumentError) The client adapter does not support streaming responses. Please use :buffer response mode.
2024-02-27T20:56:16.663181+00:00 app[web.1]: (reverse_proxy_plug 2.4.0) lib/reverse_proxy_plug.ex:427: ReverseProxyPlug.ensure_response_mode_compatibility/1
2024-02-27T20:56:16.663182+00:00 app[web.1]: (phoenix 1.7.10) lib/phoenix/router/route.ex:42: Phoenix.Router.Route.call/2
2024-02-27T20:56:16.663182+00:00 app[web.1]: (phoenix 1.7.10) lib/phoenix/router.ex:432: Phoenix.Router.__call__/5
2024-02-27T20:56:16.663183+00:00 app[web.1]: (orcasite 0.0.1) lib/orcasite_web/endpoint.ex:1: OrcasiteWeb.Endpoint.plug_builder_call/2
2024-02-27T20:56:16.663184+00:00 app[web.1]: (orcasite 0.0.1) lib/orcasite_web/endpoint.ex:1: OrcasiteWeb.Endpoint.call/2
2024-02-27T20:56:16.663184+00:00 app[web.1]: (plug_cowboy 2.6.1) lib/plug/cowboy/handler.ex:11: Plug.Cowboy.Handler.init/2
2024-02-27T20:56:16.663185+00:00 app[web.1]: (cowboy 2.11.0) /tmp/build_3e8ca230/deps/cowboy/src/cowboy_handler.erl:37: :cowboy_handler.execute/2
2024-02-27T20:56:16.663185+00:00 app[web.1]: (cowboy 2.11.0) /tmp/build_3e8ca230/deps/cowboy/src/cowboy_stream_h.erl:306: :cowboy_stream_h.execute/3

@skanderm skanderm self-assigned this Feb 27, 2024
@skanderm
Copy link
Contributor

Looks like it's related to tallarium/reverse_proxy_plug#176

@skanderm
Copy link
Contributor

@dependabot ignore this minor version

@dependabot dependabot bot closed this Feb 27, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 27, 2024

OK, I won't notify you about version 2.4.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/hex/server/reverse_proxy_plug-2.4.0 branch February 27, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants