Close button added mobile menu #295
Conversation
|
Hey can you please review my changes |
|
Follow up from PR #294 @Ayush1404 next time please update the existing PR instead of closing and opening a new one. It's a lot easier to follow along that way. Thanks! |
There was a problem hiding this comment.
Hey can you please review my changes
We're pretty limited on dev time so we do our best to review changes. On PRs this small, if they require multiple rounds of changes and you're not planning on being a regular contributor, it's more work than it's worth.
If you want to keep up with what's currently high priority and what we're working on next, please join our Slack.
we still have to put the position absolute
It can definitely be done without position: absolute, take a look at the menu icon in this very same file (this might also help).
I have added a flexbox as opposed to the previous one, we still have to put the position absolute so that we can let the button be at the left but as it is in a flexbox now the previous issue should be solved, can you please review and see if this is what you wanted?