Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure orders cannot be cancelled when they are in a pending state #32

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Luke-Rogerson
Copy link
Member

  • Make sure orders cannot be cancelled when they are in a pending state (ie. their sizePending != 0)
  • Add better filled and pending size logs for when orders are cancelled

@Luke-Rogerson Luke-Rogerson linked an issue Nov 21, 2023 that may be closed by this pull request
@uv-orbs uv-orbs merged commit b92e022 into main Nov 22, 2023
1 check passed
@uv-orbs uv-orbs deleted the feature/pending-orders-cancelling branch November 22, 2023 10:08
uv-orbs pushed a commit that referenced this pull request Nov 22, 2023
* Ensure orders cannot be cancelled when they are in a pending state

* Fix maker mock deploy hook
uv-orbs added a commit that referenced this pull request Nov 29, 2023
* working depth

* first draft

* working test

* Ensure orders cannot be cancelled when they are in a pending state (#32)

* Ensure orders cannot be cancelled when they are in a pending state

* Fix maker mock deploy hook

* deploy on any push (#34)

* deploy on any push

* deploy only on merge to main

* fix dockerfile path

* test like fashion

* before converting to e2e

---------

Co-authored-by: Luke Rogerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow orders to be cancelled that are pending
2 participants