Create seperate package for feature flags (#59)

docker-compose.yml

@@ -9,6 +9,7 @@ services:
     environment:
       - REDIS_URL=redis://db:6379/0
       - PORT=8080
+      - VERIFY_SIGNATURE=true
     depends_on:
       - db
     develop:

featureflags/flags.go

@@ -0,0 +1,8 @@
+package featureflags
+
+import "os"
+
+// Enable/disable signature verification
+//
+// It is optional whether to verify the signature or not in the order book, as it will later be verified on-chain regardless.
+var ShouldVerifySig = os.Getenv("VERIFY_SIGNATURE")

service/create_order.go

@@ -3,10 +3,10 @@ package service
 import (
 	"context"
 	"fmt"
-	"os"
 	"time"
 
 	"github.com/google/uuid"
+	"github.com/orbs-network/order-book/featureflags"
 	"github.com/orbs-network/order-book/models"
 	"github.com/orbs-network/order-book/utils"
 	"github.com/orbs-network/order-book/utils/logger"
@@ -25,11 +25,9 @@ type CreateOrderInput struct {
 	Eip712MsgData map[string]interface{}
 }
 
-var shouldVerifySig = os.Getenv("VERIFY_SIGNATURE")
-
 func (s *Service) CreateOrder(ctx context.Context, input CreateOrderInput) (models.Order, error) {
 
-	if shouldVerifySig == "" || shouldVerifySig == "true" {
+	if featureflags.ShouldVerifySig == "" || featureflags.ShouldVerifySig == "true" {
 		logctx.Info(ctx, "verifying signature", logger.String("userId", input.UserId.String()))
 
 		user := utils.GetUserCtx(ctx)