Update README.md #147
Merged
Update README.md #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing sample in readme
oracle-contributor-agreement
bot
added
the
OCA Verified
jjspiegel
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Could you please move it before Jackson ObjectNode in the list?
Reasoning: mapping to ObjectNode is a fringe case since it would be better to map directly to OracleJsonValue in such cases as it doesn't incur materialization costs. On the other hand, using collection tables with this feature seems very useful.
jeandelavarene
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing sample in readme