Teking into account samples review comments #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Are we not supposed to have copyrights in these files ? |
|
What about moving tests in Junit test classes as opposed to within a "main" method ? |
You are right, thank you! |
They are not supposed to be tests but code samples. |
jeandelavarene
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add oson provider source and tests * Update JDK to 11 * Fix tests runs * Fix Encoding Test. * Update Jackson version and cleaned up pom dependencies and parameters * Fix Temporal Annotations and Support UUID to be parsed as byte[] instead of String. * Add jakarta persistence API for Annotations. * Teking into account samples review comments (#126) * Teking into account samples review comments * Added Copyright * Update AccessJsonColumnUsingJacksonObjectNode.java (#127) * Add more Serializers/Deserializers and lots of fixed to support Jakarta annotations. Added more Tests. * Fixes. Improved support with Hibernate. * Removed AnnotationIntrospector.java as it's being done in hibernate. * Save LocalDate as Oson Date. Update README.md * add "java.net" package from the skip list. * Added javadoc. Cleanup. Modified README.md and addressed comments. * cleanup. * Added logging. * Fixed pom.xm and update README.md * Updated Javadoc and add code samples. * Remove {extention-version} variable from modules. --------- Co-authored-by: Bidyadhar Mohanty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.