Adding Glob support for Data lake #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ramackri
changed the title
ahosler
requested changes
Feb 26, 2024
| @@ -1274,6 +1274,42 @@ def walk(self, path, maxdepth=None, **kwargs): | |||
| raise ValueError("Cannot crawl all of OCI Object Storage") | |||
| return super().walk(path, maxdepth=maxdepth, **kwargs) | |||
|
|
|||
| def glob(self, path, maxdepth=None, **kwargs): | |||
There was a problem hiding this comment.
Shouldn't this be in the ocilake specific implementation file?
There was a problem hiding this comment.
if the URI contains lake then the customized logic will be executed otherwise fs spec custom implementation will be invoked. We used self.split_path(path) (which is mentioned inside core.py ---> will fetch bucket/namespace info from lake service).This custom logic will not create any impact on the existing use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to customize the glob fs spec for Lake support which needs to be implemented in ocifs python library
