-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oke oss release 1.29.2 #490
Merged
YashwantGohokar
merged 9 commits into
oracle:release-1.29
from
YashwantGohokar:oke-oss-release-1.29.2
Feb 18, 2025
Merged
Oke oss release 1.29.2 #490
YashwantGohokar
merged 9 commits into
oracle:release-1.29
from
YashwantGohokar:oke-oss-release-1.29.2
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hyphen with colon in SS IPv6 NodeNames to get the IPs Account for changes in vnic.PrimaryIP field being null for vnics belonging to SS IPv6 subnet
New E2E for testing LB & NLB creation with ReserveIP using Workload Identity Resource Principal Fixing a logical issue with the existing Wris E2E cleanup
Map the display name of NLB to an OCID to avoid looking it up again in each reconciliation.
b1a7a66
to
4e4f9b5
Compare
LGTM. Please do not mention IPv6 related changes in the changelog. |
l-technicore
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please do not mention IPv6 related changes in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
E2E Results:
e2e-1-29.log
e2e-1-29-rb.log
e2e-1-29-failed.log