Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oke oss release 1.30.1 #489

Merged

Conversation

YashwantGohokar
Copy link
Member

@YashwantGohokar YashwantGohokar commented Feb 18, 2025

Changelog:

  • Support for Workload Identity in GetReservedIP calls
  • Support for gRPC Protocol on OKE managed LB and add e2e test cas
  • Check lifecycle state for NLB instead of listing workrequest in the compartment
  • Skip Cipher Suite Update on Listeners and Backendsets when Unspecified
  • Provide an option to skip private IP in LB Status for public NLBs
  • NLB display name to OCID map - Map the display name of NLB to an OCID to avoid looking it up again in each
  • reconciliation.
  • Bumped dependency versions and fix e2e

E2E Results:
e2e-1.30.log
e2e-1.30-2.log
e2e-1.30-3.log

l-technicore and others added 8 commits February 16, 2025 22:32
Replace hyphen with colon in SS IPv6 NodeNames to get the IPs
Account for changes in vnic.PrimaryIP field being null for vnics belonging to SS IPv6 subnet
New E2E for testing LB & NLB creation with ReserveIP using Workload Identity Resource Principal
Fixing a logical issue with the existing Wris E2E cleanup
Map the display name of NLB to an OCID to avoid looking it up again in each
reconciliation.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 18, 2025
@coveralls
Copy link

coveralls commented Feb 18, 2025

Pull Request Test Coverage Report for Build 13386704939

Details

  • 118 of 250 (47.2%) changed or added relevant lines in 17 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 32.444%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/providers/oci/ccm.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/csi/driver/lustre_node.go 0 1 0.0%
pkg/oci/client/client_factory.go 0 1 0.0%
pkg/oci/client/compute.go 0 1 0.0%
pkg/volume/provisioner/core/provisioner.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_util.go 5 7 71.43%
pkg/oci/client/network_load_balancer.go 26 29 89.66%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 29 34 85.29%
pkg/csi/driver/fss_controller.go 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 32.39%
Totals Coverage Status
Change from base Build 13300688558: 0.8%
Covered Lines: 5121
Relevant Lines: 15784

💛 - Coveralls

@YashwantGohokar YashwantGohokar force-pushed the oke-oss-release_1.30.1 branch 2 times, most recently from 2fc1b42 to f64c194 Compare February 18, 2025 07:56
@l-technicore l-technicore self-requested a review February 18, 2025 10:46
Copy link
Member

@l-technicore l-technicore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please do not mention IPv6 related changes in the changelog.

@YashwantGohokar YashwantGohokar merged commit a14c45d into oracle:release-1.30 Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants