Make IGV start on GraalVM 24.0.1 #11409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
JaroslavTulach
commented
Jun 14, 2025
| @@ -117,7 +117,7 @@ | |||
| <module>ViewerApi</module> | |||
| </modules> | |||
| <properties> | |||
| <netbeans.version>RELEASE220</netbeans.version> | |||
| <netbeans.version>RELEASE260</netbeans.version> | |||
There was a problem hiding this comment.
With this change I can built regularly:
/graal/visualizer/IdealGraphVisualizer$ JAVA_HOME=/graalvm-21/ mvn installand then execute on GraalVM 24.0.1 (which was failing previously):
/graal/visualizer/IdealGraphVisualizer$ JAVA_HOME=/graalvm-24 mvn -f application/ \
-Dexec.vmArgs= -Dexec.appArgs= \
nbm:cluster-app nbm:run-platform
19 tasks
JaroslavTulach
commented
Jun 14, 2025
| @@ -45,7 +46,12 @@ | |||
| public class GraphTypeModeSelector implements ModeSelector { | |||
| @Override | |||
| public Mode selectModeForOpen(TopComponent tc, Mode mode) { | |||
| if (tc.getLookup().lookup(InputGraph.class) == null) { | |||
| try { | |||
| if (tc.getLookup().lookup(InputGraph.class) == null) { | |||
There was a problem hiding this comment.
Without this change I couldn't open any file in the editor. I was getting exception like this one
With following command line the execution gets further: why IGV needs to access graphio.parsing from a JDK and how you want to make sure it gets the right version on different JVMs, is beyond ambitions of this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have problems launching IGV on GraalVM 24.0.1. It yields following error:
The problem is that JDK 24 has removed SecurityManager support and as the NetBeans Platform launcher needs to be adjusted to that. Such an adjustment has happened in NetBeans 26. Hence upgrading.