Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-61453] Simple computation of instance size. #10523

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[GR-61453] Simple computation of instance size. #10523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef4b0e
Simple computation of instance size.
rakachan Jan 20, 2025
8f40206
Link implemented StaticObject.getObjectSize to instrument substitution.
rakachan Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...sso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/impl/ObjectKlass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import com.oracle.truffle.espresso.analysis.hierarchy.SingleImplementor;
import com.oracle.truffle.espresso.blocking.EspressoLock;
import com.oracle.truffle.espresso.classfile.ConstantPool;
import com.oracle.truffle.espresso.classfile.JavaKind;
import com.oracle.truffle.espresso.classfile.ParserField;
import com.oracle.truffle.espresso.classfile.ParserKlass;
import com.oracle.truffle.espresso.classfile.ParserMethod;
Expand Down Expand Up @@ -1710,6 +1711,22 @@ public Source getSource() {
return getKlassVersion().getSource();
}

public long getInstanceSize() {
return computeInstanceSize();
}

@TruffleBoundary
private long computeInstanceSize() {
if (fieldTable.length == 0) {
return 0L;
}
long size = 0L;
for (Field f : getFieldTable()) {
size += f.getKind() == JavaKind.Object ? JavaKind.Long.getByteCount() : f.getKind().getByteCount();
}
return size;
}

public final class KlassVersion {
final Assumption assumption;
final RuntimeConstantPool pool;
Expand Down
22 changes: 22 additions & 0 deletions ...e.truffle.espresso/src/com/oracle/truffle/espresso/runtime/staticobject/StaticObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.oracle.truffle.espresso.EspressoLanguage;
import com.oracle.truffle.espresso.blocking.BlockingSupport;
import com.oracle.truffle.espresso.blocking.EspressoLock;
import com.oracle.truffle.espresso.classfile.JavaKind;
import com.oracle.truffle.espresso.descriptors.EspressoSymbols.Types;
import com.oracle.truffle.espresso.impl.ArrayKlass;
import com.oracle.truffle.espresso.impl.EspressoType;
Expand Down Expand Up @@ -190,6 +191,27 @@ public final boolean isStaticStorage() {
return this == getKlass().getStatics();
}

public final long getObjectSize(EspressoLanguage language) {
if (isNull(this)) {
return 0L;
}
long size = 0L;
size += JavaKind.Long.getByteCount(); // Klass storage
size += JavaKind.Long.getByteCount(); // Monitor storage
if (isForeignObject()) {
size += JavaKind.Long.getByteCount(); // Foreign storage
size += JavaKind.Long.getByteCount(); // Type Argument storage
} else if (getKlass() instanceof ArrayKlass k) {
JavaKind componentKind = k.getComponentType().getJavaKind();
size += (long) (componentKind == JavaKind.Object ? JavaKind.Long.getByteCount() : componentKind.getByteCount()) * length(language);
} else if (getKlass() instanceof ObjectKlass k) {
size += k.getInstanceSize();
} else {
EspressoContext.get(null).getLogger().warning(() -> "Unknown static object with class " + getKlass());
}
return size;
}

/**
* Given a guest Class, get the corresponding Klass. This method has the disadvantage of not
* being able to constant fold the {@link Meta} object that is extracted from {@code this} if
Expand Down
8 changes: 4 additions & 4 deletions .../com/oracle/truffle/espresso/substitutions/Target_sun_instrument_InstrumentationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.List;

import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
import com.oracle.truffle.espresso.EspressoLanguage;
import com.oracle.truffle.espresso.classfile.ClasspathEntry;
import com.oracle.truffle.espresso.descriptors.EspressoSymbols.Names;
import com.oracle.truffle.espresso.descriptors.EspressoSymbols.Signatures;
Expand Down Expand Up @@ -134,10 +135,9 @@ private static StaticObject toGuestClassArray(EspressoContext context, List<Klas
public static long getObjectSize0(
@SuppressWarnings("unused") StaticObject self,
@SuppressWarnings("unused") long agentId,
@SuppressWarnings("unused") @JavaType(Object.class) StaticObject object,
@Inject EspressoContext context) {
throw context.getMeta().throwExceptionWithMessage(context.getMeta().java_lang_UnsupportedOperationException,
"Espresso VM doesn't support getting object size from java agents. This restriction will be lifted in later versions.");
@JavaType(Object.class) StaticObject object,
@Inject EspressoLanguage language) {
return object.getObjectSize(language);
}

@Substitution(hasReceiver = true)
Expand Down