Include Charset for sun.jnu.encoding by default
#10232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Charset` specified by `sun.jnu.encoding` is required e.g. for `java.(n)io` path encoding/decoding as the image inherits `sun.jnu.encoding` from the build environment. On Windows, this will typically be a legacy code page charset, which is otherwise not added by default.
oracle-contributor-agreement
bot
added
the
OCA Verified
Makes sense to me. @fmeum did you check how much this increases the size of a helloworld image on Windows? |
olpaw
requested changes
Dec 16, 2024
There was a problem hiding this comment.
@fmeum I also need a test case that would fail without this change.
See also #10232 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Charsetspecified bysun.jnu.encodingis required e.g. forjava.(n)iopath encoding/decoding as the image inheritssun.jnu.encodingfrom the build environment. On Windows, this will typically be a legacy code page charset, which is otherwise not added by default.