ODSC 68406: AutoMLx Global Explainer #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ahosler
reviewed
Feb 13, 2025
| @@ -453,6 +453,12 @@ def explain_model(self): | |||
|
|
|||
| # Store the explanations in the local_explanation dictionary | |||
| self.local_explanation[s_id] = explanations_df | |||
|
|
|||
| self.global_explanation[s_id] = dict(zip( | |||
| data_i.columns[1:], | |||
There was a problem hiding this comment.
is it always guaranteed that "data_i.columns[1:]" will exclude the correct column?
Are there tests to detect a break in this logic incase we change the order of the columns later?
There was a problem hiding this comment.
yes, resolved this, does not need any subsetting now
codeloop
changed the title
codeloop
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
ahosler
requested changes
Feb 16, 2025
| self.formatted_global_explanation = ( | ||
| global_explanation_df / global_explanation_df.sum(axis=0) * 100 | ||
| ) | ||
| self.formatted_global_explanation = ( |
There was a problem hiding this comment.
would this be better to do with inplace=True ?
| @@ -424,8 +430,10 @@ def explain_model(self): | |||
| if self.spec.explanations_accuracy_mode == SpeedAccuracyMode.AUTOMLX: | |||
| # Use the MLExplainer class from AutoMLx to generate explanations | |||
| explainer = automlx.MLExplainer( | |||
| self.models[s_id]["model"], | |||
| self.datasets.additional_data.get_data_for_series(series_id=s_id) | |||
| self.models[s_id], | |||
There was a problem hiding this comment.
Should we be dropping ["model"]? I believe Prashant added this for inverse_transforming non-numerical columns
There was a problem hiding this comment.
missed in the merge conflicts, Thanks!.
ahosler
previously approved these changes
Feb 17, 2025
ahosler
approved these changes
Feb 18, 2025
sambitkumohanty
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODSC 68406: AutoMLx Global Explainer