[ready to review] ODSC-68841: API Returns Data Directly #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahosler
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
|
|
mrDzurb
previously approved these changes
Feb 6, 2025
|
|
|
|
ahosler
changed the title
|
|
|
|
📌 Cov diff with main: 📌 Overall coverage: |
codeloop
reviewed
Feb 17, 2025
| model = Prophet(**params) | ||
| if monthly_seasonality: | ||
| model.add_seasonality(name="monthly", period=30.5, fourier_order=5) |
There was a problem hiding this comment.
Do we need to specify this, wouldn;t this be auto-tuned/optimized internally.
There was a problem hiding this comment.
Prophet doesn't natively support it, they recommend adding it as a custom seasonality. Unfortunately thats hard to do with our yaml file
If you go to "Specifying Custom Seasonalities" section here: https://facebook.github.io/prophet/docs/seasonality,_holiday_effects,_and_regressors.html
ahosler
changed the title
darenr
approved these changes
Feb 17, 2025
mrDzurb
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.