Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 support for cpuinfo module #6

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Hannibal404
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 28, 2023
Signed-off-by: Pradyumn Rahar <[email protected]>
@Hannibal404
Copy link
Member Author

Fixes #8 with 823f9cb

Copy link
Member

@brenns10 brenns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit regarding tests, but otherwise it looks good.

I rebased it on top of #20 and ran the vmcore tests against the full suite - it passes, and fixes the one regression in #8. Thanks for this!

tests/test_cpuinfo.py Show resolved Hide resolved
@brenns10 brenns10 merged commit 4a654a0 into oracle-samples:main Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants