Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6.0 #43

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Release v0.6.0 #43

merged 10 commits into from
Dec 8, 2023

Conversation

brenns10
Copy link
Member

@brenns10 brenns10 commented Dec 5, 2023

This pull request is again a bit of a mixture.

  1. I made sure we standardize on using cpu_curr() for getting the current task, as it's the correct way.
  2. I added the corelens boilerplate for irq, which had good helpers but no corelens module yet.
  3. I made sure that ps command will succeed when running as part of a bulk corelens run (set default arg to -m).
  4. The NFS tests were put into the wrong directory, I fixed that.
  5. I added support to drgn-tools CLI to specify CTF debuginfo, it will be useful for testing.
  6. I added changelog entries and prepared the v0.6.0 release.
  7. After the v0.6.0 release, I added some code into the test frameworks that makes it possible for me to run drgn-tools tests with a drgn that has CTF enabled. This doesn't mean CTF tests are running in any CI system, it just means I can run them manually, but it's a good start.

There have been a few ways of getting the current task on a CPU, but the
correct way is drgn's cpu_curr(). Standardize on that, and get rid of
the unnecessary helper get_current_task().

Signed-off-by: Stephen Brennan <[email protected]>
The print_all_irqs() function already existed thanks to Imran. Just wrap
it in a corelens module to make it available.

Signed-off-by: Stephen Brennan <[email protected]>
For posterity: I used sphinx-apidoc to automatically generate the file,
and then made some quick changes to it.

Signed-off-by: Stephen Brennan <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 5, 2023
The node_zones array can never have a null entry (it is an array of
structs, not pointers). Instead, rely on the nr_zones field alongside
it.

Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
The litevm tests are trivial to run with CTF: the CTF information is
right there in the kernel RPM which gets mounted to /lib/modules in the
VM. For vmcore tests, we must manually load the CTF path, vmlinux.ctfa,
in the vmcore directory.

To support this, updated the conftest with relevant configuration and
parsing. Then, add a --ctf flag to both the vmcore and the litevm test
runners.

Note that this doesn't mean that we are running tests with CTF on any
CI. The CI commands still need to be adjusted to run CTF, and the CI
systems themselves aren't yet configured to install a CTF enabled
version of drgn. However, this means that I can manually run the
drgn-tools test suite against CTF enabled drgn builds, which is very
helpful for finding bugs.

Signed-off-by: Stephen Brennan <[email protected]>
@brenns10 brenns10 merged commit 08b7f94 into oracle-samples:main Dec 8, 2023
5 checks passed
@brenns10 brenns10 deleted the release_0.6.0 branch December 8, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants