Fixes for CI failures #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proc_do_large_bitmap() function prints a bitmap in a string representation, but the bitmap is not stored as a string. Treating it as such results in FaultErrors. Fixes: 2385230 ("kernfs,memcg: Fix CI failure for UEK4.") Signed-off-by: Stephen Brennan <[email protected]>
The CSS_DYING flag was only introduced in 33c35aa481786 ("cgroup:
Prevent kill_css() from being called more than once"), which was
introduced in v4.12, but present in some backports. Since we only need
to refer to this constant in order to get the enum type, use CSS_ONLINE,
which has been present since v3.8.
Fixes: 30e57f6 ("kernfs,memcg: Add helpers to get memcg info")
Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
The max_scan parameter of dump_page_cache_pages_pinning_cgroups() only allows limiting the number of matching pages which are printed. For systems or vmcores where there are (a) many pages, and (b) no matching pages, this means that all pages (or nearly all) are scanned before the function can terminate. This isn't really a problem for the corelens module: users must run it manually (not as part of any report). If it runs too long, they may interrupt it with Ctrl-C. But for CI testing, the function runs too long in some cases. So, introduce a max_scan parameter that limits the number of pages considered. The test limits the scan count to a million, which seems more than enough. The max_scan parameter is not exposed to the corelens module, but it can be at a later date if a need arises. Signed-off-by: Stephen Brennan <[email protected]>
biger410
approved these changes
Jan 3, 2025
|
CI passed on Github and Gitlab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to recent changes - one in the kernfs_memcg code, and one in the sysctl code. Both of these are only present in the
mainbranch so no backport is required. Since they're fixes to such recent code, I haven't created a bug for them.