Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10665] fix: Github Actions YAML files vulnerable to script injections corrected #284

Merged

Conversation

FarhanAnjum-opti
Copy link
Contributor

Summary

Instead of directly using variables that can contain user input, new intermediate variables were introduced so that script injection attacks could be mitigated.

Issues

Copy link

Jest Coverage Report

St.
Category Percentage Covered / Total
🟢 Statements 98.95% 847/856
🟢 Branches 91.64% 340/371
🟢 Functions 97.52% 157/161
🟢 Lines 99.09% 765/772

Test suite run success

258 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from a6a784d

Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@FarhanAnjum-opti FarhanAnjum-opti merged commit 1197fb2 into master Sep 25, 2024
14 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the farhan/FSSDK-10665-github-actions-correction branch September 25, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants