Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9913] chore: update dependencies & fixes from testing #230

Merged
merged 4 commits into from
Jan 23, 2024
Merged

[FSSDK-9913] chore: update dependencies & fixes from testing #230

merged 4 commits into from
Jan 23, 2024

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Update the JS SDK version to released 5.0.0
  • Corrected follow-on type update changes
  • Quality of life in dev container updates

Test plan

  • Unit tests should pass
  • FSC test should continue to pass
  • Completed manual user acceptance testing, consuming this branch into a React app

Issues

@mikechu-optimizely
Copy link
Contributor Author

Developer code review completed.

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review January 23, 2024 20:27
@mikechu-optimizely mikechu-optimizely requested a review from a team January 23, 2024 20:28
jaeopt
jaeopt approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit a441b07 into master Jan 23, 2024
7 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/FSSDK-9913/dep-updates branch January 23, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@raju-opti raju-opti Awaiting requested review from raju-opti

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @jaeopt