Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9745] fix: updated datafile variable in README #224

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

farhan-opti
Copy link
Contributor

Summary

  • Changed window datafile variable to optimizelyDatafile

The "why"

README doc was out of sync with Developer docs

Test plan

It is a documentation update, thus not needed

Issues

@farhan-opti farhan-opti requested a review from a team November 3, 2023 18:44
@mikechu-optimizely mikechu-optimizely added the documentation Improvements or additions to documentation label Nov 6, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhan-opti farhan-opti merged commit c4afe04 into master Nov 6, 2023
5 checks passed
@farhan-opti farhan-opti deleted the fssdk-9745 branch November 6, 2023 16:05
@mikechu-optimizely mikechu-optimizely changed the title fix: updated datafile variable in README [FSSDK-9745] fix: updated datafile variable in README Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants