Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9494] Tag release correctly during publishing #220

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[FSSDK-9494] Tag release correctly during publishing #220

merged 2 commits into from
Oct 20, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Sep 26, 2023 •
edited
Loading

Summary

  • Update the release workflow to read the package.json and tag the release in NPM correctly:
    • beta
    • alpha
    • rc
    • else latest

Test plan

Issues

  • FSSDK-9494

@mikechu-optimizely mikechu-optimizely requested review from raju-opti and a team and removed request for raju-opti September 26, 2023 18:05
raju-opti
raju-opti approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔

@mikechu-optimizely mikechu-optimizely merged commit 380a1d8 into master Oct 20, 2023
6 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/tag-correctly-during-publish branch October 20, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @raju-opti