Add await to relevent setuser tests

Author: rafinutshaw-optimizely

src/client.spec.ts

@@ -143,7 +143,7 @@ describe('ReactSDKClient', () => {
     });
 
     it('fulfills the returned promise with success: true when a user is set', async () => {
-      instance.setUser({
+      await instance.setUser({
         id: 'user12345',
       });
       const result = await instance.onReady();
@@ -164,7 +164,7 @@ describe('ReactSDKClient', () => {
       });
 
       it('fulfills the returned promise with success: false when a user is set', async () => {
-        instance.setUser({
+        await instance.setUser({
           id: 'user12345',
         });
         const result = await instance.onReady();
@@ -178,7 +178,7 @@ describe('ReactSDKClient', () => {
           resolveInnerClientOnReady = res;
         });
         mockInnerClientOnReady.mockReturnValueOnce(mockReadyPromise);
-        instance.setUser({
+        await instance.setUser({
           id: 'user999',
         });
         resolveInnerClientOnReady!({ success: true });
@@ -194,7 +194,7 @@ describe('ReactSDKClient', () => {
         resolveInnerClientOnReady = res;
       });
       mockInnerClientOnReady.mockReturnValueOnce(mockReadyPromise);
-      instance.setUser({
+      await instance.setUser({
         id: 'user999',
       });
       resolveInnerClientOnReady!({ success: true });
@@ -204,9 +204,9 @@ describe('ReactSDKClient', () => {
   });
 
   describe('setUser', () => {
-    it('updates the user object with id and attributes', () => {
+    it('updates the user object with id and attributes', async () => {
       const instance = createInstance(config);
-      instance.setUser({
+      await instance.setUser({
         id: 'xxfueaojfe8&86',
         attributes: {
           foo: 'bar',
@@ -256,9 +256,9 @@ describe('ReactSDKClient', () => {
 
     describe('pre-set user and user overrides', () => {
       let instance: ReactSDKClient;
-      beforeEach(() => {
+      beforeEach(async () => {
         instance = createInstance(config);
-        instance.setUser({
+        await instance.setUser({
           id: 'user1',
           attributes: {
             foo: 'bar',
@@ -913,7 +913,7 @@ describe('ReactSDKClient', () => {
       });
 
       describe('if Optimizely client is null', () => {
-        it('does not return an object with variables of all types returned from the inner sdk ', () => {
+        it('does not return an object with variables of all types returned from the inner sdk ', async () => {
           (mockInnerClient.getOptimizelyConfig as jest.Mock).mockReturnValue({
             featuresMap: {
               feat1: {
@@ -971,7 +971,7 @@ describe('ReactSDKClient', () => {
             }
           );
           const instance = createInstance(config);
-          instance.setUser({
+          await instance.setUser({
             id: 'user1123',
           });
           // @ts-ignore
@@ -981,7 +981,7 @@ describe('ReactSDKClient', () => {
         });
       });
 
-      it('returns an object with variables of all types returned from the inner sdk ', () => {
+      it('returns an object with variables of all types returned from the inner sdk ', async () => {
         (mockInnerClient.getOptimizelyConfig as jest.Mock).mockReturnValue({
           featuresMap: {
             feat1: {
@@ -1039,7 +1039,7 @@ describe('ReactSDKClient', () => {
           }
         );
         const instance = createInstance(config);
-        instance.setUser({
+        await instance.setUser({
           id: 'user1123',
         });
         const result = instance.getFeatureVariables('feat1');
@@ -1057,7 +1057,7 @@ describe('ReactSDKClient', () => {
 
     describe('getAllFeatureVariables', () => {
       describe('if Optimizely client is null', () => {
-        it('does not return an object with variables of all types returned from the inner sdk ', () => {
+        it('does not return an object with variables of all types returned from the inner sdk ', async () => {
           const anyClient = mockInnerClient.getAllFeatureVariables as jest.Mock;
           anyClient.mockReturnValue({
             bvar: true,
@@ -1071,14 +1071,14 @@ describe('ReactSDKClient', () => {
           const instance = createInstance(config);
           // @ts-ignore
           instance._client = null;
-          instance.setUser({
+          await instance.setUser({
             id: 'user1123',
           });
           const result = instance.getAllFeatureVariables('feat1', 'user1');
           expect(result).toEqual({});
         });
 
-        it('cannot use pre-set and override user for getAllFeatureVariables', () => {
+        it('cannot use pre-set and override user for getAllFeatureVariables', async () => {
           const mockFn = mockInnerClient.getAllFeatureVariables as jest.Mock;
           mockFn.mockReturnValue({
             bvar: true,
@@ -1092,7 +1092,7 @@ describe('ReactSDKClient', () => {
           const instance = createInstance(config);
           // @ts-ignore
           instance._client = null;
-          instance.setUser({
+          await instance.setUser({
             id: 'user1',
             attributes: {
               foo: 'bar',
@@ -1111,7 +1111,7 @@ describe('ReactSDKClient', () => {
         expect(result).toEqual({});
       });
 
-      it('returns an object with variables of all types returned from the inner sdk ', () => {
+      it('returns an object with variables of all types returned from the inner sdk ', async () => {
         const anyClient = mockInnerClient.getAllFeatureVariables as jest.Mock;
         anyClient.mockReturnValue({
           bvar: true,
@@ -1123,7 +1123,7 @@ describe('ReactSDKClient', () => {
           },
         });
         const instance = createInstance(config);
-        instance.setUser({
+        await instance.setUser({
           id: 'user1123',
         });
         const result = instance.getAllFeatureVariables('feat1', 'user1');
@@ -1138,7 +1138,7 @@ describe('ReactSDKClient', () => {
         });
       });
 
-      it('can use pre-set and override user for getAllFeatureVariables', () => {
+      it('can use pre-set and override user for getAllFeatureVariables', async () => {
         const mockFn = mockInnerClient.getAllFeatureVariables as jest.Mock;
         mockFn.mockReturnValue({
           bvar: true,
@@ -1150,7 +1150,7 @@ describe('ReactSDKClient', () => {
           },
         });
         const instance = createInstance(config);
-        instance.setUser({
+        await instance.setUser({
           id: 'user1',
           attributes: {
             foo: 'bar',
@@ -1215,7 +1215,7 @@ describe('ReactSDKClient', () => {
     });
 
     it('should return false if fetch fails', async () => {
-      instance.setUser({
+      await instance.setUser({
         id: 'user1',
       });
 
@@ -1226,7 +1226,7 @@ describe('ReactSDKClient', () => {
     });
 
     it('should return true if fetch successful', async () => {
-      instance.setUser({
+      await instance.setUser({
         id: 'user1',
       });
 
@@ -1239,9 +1239,9 @@ describe('ReactSDKClient', () => {
 
   describe('onForcedVariationsUpdate', () => {
     let instance: ReactSDKClient;
-    beforeEach(() => {
+    beforeEach(async () => {
       instance = createInstance(config);
-      instance.setUser({
+      await instance.setUser({
         id: 'xxfueaojfe8&86',
         attributes: {
           foo: 'bar',
@@ -1293,10 +1293,10 @@ describe('ReactSDKClient', () => {
     });
 
     describe('if Optimizely client is null', () => {
-      it('should return false', () => {
+      it('should return false', async () => {
         // @ts-ignore
         instance._client = null;
-        instance.setUser({
+        await instance.setUser({
           id: 'user1',
         });
         const mockFn = mockOptimizelyUserContext.removeAllForcedDecisions as jest.Mock;
@@ -1310,8 +1310,8 @@ describe('ReactSDKClient', () => {
       });
     });
 
-    it('should return true if  user context has been set ', () => {
-      instance.setUser({
+    it('should return true if  user context has been set ', async () => {
+      await instance.setUser({
         id: 'user1',
       });
       const mockFn = mockOptimizelyUserContext.removeAllForcedDecisions as jest.Mock;
@@ -1327,9 +1327,9 @@ describe('ReactSDKClient', () => {
 
   describe('setForcedDecision', () => {
     let instance: ReactSDKClient;
-    beforeEach(() => {
+    beforeEach(async () => {
       instance = createInstance(config);
-      instance.setUser({
+      await instance.setUser({
         id: 'user1',
         attributes: {
           foo: 'bar',
@@ -1436,9 +1436,9 @@ describe('ReactSDKClient', () => {
 
   describe('removeForcedDecision', () => {
     let instance: ReactSDKClient;
-    beforeEach(() => {
+    beforeEach(async () => {
       instance = createInstance(config);
-      instance.setUser({
+      await instance.setUser({
         id: 'user1',
         attributes: {
           foo: 'bar',