Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marketo Form Extension files #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dslachtman
Copy link
Contributor

This is the editor extension to add a Marketo Form to a Page in Optimizely.

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@asaschachar asaschachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added one comment, but overall I think this looks great.

Appreciate the thoughtfulness you put into the readme to help users use the extension correctly!

![Screenshot](https://raw.githubusercontent.com/dslachtman/Add-Marketo-Form-Extension/master/extension_fields.png?token=ABLN7RHBCGLSQZUNKQHLNMC46WM3A)

This is how the fields correspond to the Marketo code:
![Screenshot](https://raw.githubusercontent.com/dslachtman/Add-Marketo-Form-Extension/master/marketo_code.png?token=ABLN7RE37I45XI2CSGIUID246WNCW)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great screenshots!

"edit_page_url": "https://www.atticandbutton.us/",
"form_schema": [
{
"default_value": "https://app-123.marketo.com/js/forms2/js/forms2.min.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the format of this url always have the same pattern? like "https://app-.marketo.com/js/forms2/js/forms2.min.js"

Right now the extension code is kind of generically inserting a script from some location and if the user accidentally puts in the wrong URL, they could be loading the wrong or potentially even malicious script on their page.

One way around this might be to only allow users to configure the so that we always guarantee that this extension adds a script from a marketo domain. However, this assumes marketo won't change the format of their URL.

Or we could rely on users to ensure they paste in the right script here as you are doing here.

I think this is fine either way, but would appreciate your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants