-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker compose for 1.0.0 #4655
base: develop
Are you sure you want to change the base?
Conversation
ports: | ||
- 8000:8000 | ||
volumes: | ||
- "storage_data:${INFRAHUB_STORAGE_LOCAL_PATH:-/opt/infrahub/storage}" | ||
- "workflow_data:/opt/infrahub/workflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this volume anymore, but I still see it in the development docker-compose...
Can you confirm @dgarros?
I'm asking because we removed it from the Helm chart, and it seems to be still working. If the volume is still required, we'd need to also fix the Helm chart.
I realise that we don't have the variables for specific SSO providers.
Also perhaps unrelated to this PR but is there a reason why we redefine the default values within the docker compose file? |
Co-authored-by: fatih-acar <[email protected]>
Co-authored-by: fatih-acar <[email protected]>
We redefine the default to make it more "visible" for the users to see what they can change and why some data are like this. Regarding all the SSO PROVIDER Data, I could had all of them but that seem quite a lot to add for empty value on top on the rest. We could set all of them in another x-infrahub-config-sso section maybe 🤔 |
Ok, was thinking that it's mostly just duplicating data. I also want to get back to generating the configuration in the docs in a proper way. Perhaps that's the main issue behind this that the docs on the config are a bit confusing..
Alternatively we just ignore it. I think this Docker file is mostly to get up and running quickly and in a real production environment users would use something else regardless? |
We actually redefine default values in order to use them in the dependencies, such as the message broker auth credentials, cache credentials, etc |
As well as the address which are |
cache
service itself @fatih-acar