Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand on meaning and examples of Relationship Kinds #4631

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Expand on meaning and examples of Relationship Kinds #4631

wants to merge 4 commits into from
+119 −5

Conversation

BeArchiTek
Copy link
Contributor

Fixes #3032

@BeArchiTek BeArchiTek added the type/documentation Improvements or additions to documentation label Oct 15, 2024
@BeArchiTek BeArchiTek requested a review from a team October 15, 2024 12:59
@BeArchiTek BeArchiTek self-assigned this Oct 15, 2024
@BeArchiTek BeArchiTek added the ci/skip-changelog Don't include this PR in the changelog label Oct 15, 2024
wvandeun
wvandeun requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@wvandeun wvandeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a few improvements to be done in the example and some of the explanations, see inline comments.

docs/docs/topics/schema.mdx Outdated Show resolved Hide resolved
docs/docs/topics/schema.mdx Outdated Show resolved Hide resolved
docs/docs/topics/schema.mdx Outdated Show resolved Hide resolved
docs/docs/topics/schema.mdx Outdated Show resolved Hide resolved
docs/docs/topics/schema.mdx Show resolved Hide resolved
docs/docs/topics/schema.mdx Show resolved Hide resolved
docs/docs/topics/schema.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvandeun wvandeun Awaiting requested review from wvandeun

Requested changes must be addressed to merge this pull request.

Assignees

@BeArchiTek BeArchiTek

Labels
ci/skip-changelog Don't include this PR in the changelog type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task: Docs Improvement - Expand on meaning and examples of Relationship Kinds
2 participants
@BeArchiTek @wvandeun