Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for context to InfrahubDatabase #4628

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

dgarros
Copy link
Collaborator

@dgarros dgarros commented Oct 15, 2024

This PR is related to the effort around the query_performance tests

Currently we are using storing the results in a global variables because we couldn't easily insert them to the InfrahubDatabaseProfiler class

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 15, 2024
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #4628 will degrade performances by 17.01%

Comparing dga-20241015-queryanalyzer (d0db954) with develop (bbc7d6f)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop dga-20241015-queryanalyzer Change
test_get_menu 889.5 µs 763.6 µs +16.49%
test_schemabranch_duplicate 309.6 µs 373.1 µs -17.01%

@LucasG0 LucasG0 marked this pull request as ready for review October 15, 2024 10:56
@LucasG0 LucasG0 merged commit cffafd3 into develop Oct 15, 2024
30 of 31 checks passed
@LucasG0 LucasG0 deleted the dga-20241015-queryanalyzer branch October 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants