Integrate python SDK into main python project #4625
Conversation
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #4625 will not alter performanceComparing Summary
|
dgarros
force-pushed
the
dga-20241014-fix-4234
branch
from
a50821a
to
2bee55e
Compare
|
|
||
| from pydantic import BaseModel, Field | ||
| from typing_extensions import Self |
There was a problem hiding this comment.
Are these changes something that happened when the wrong Python version was running? It doesn't seem like something that would be required.
There was a problem hiding this comment.
Yes and No
it was uncovered because the tests did run with 3.10 instead of 3.12 but officially we should support 3.10 (pyproject.toml) so we shouldn't use a 3.11 feature.
| optional = true | ||
| packages = [ | ||
| { include = "infrahub", from = "backend" }, | ||
| { include = "infrahub_sdk", from = "python_sdk" } |
There was a problem hiding this comment.
I'm wondering how this will behave on systems where where we want to install both the SDK and infrahub-server if one of them overwrites the other. It should mostly be relevant for testing purposes like when we want to install infrahub-server within the SDK repo during CI. I.e if the infrahub_sdk folder gets overwritten by the latest package of what happens.
There was a problem hiding this comment.
Yes for now there will be a conflict but I think the risk is limited for now.
it will take a few more steps to fix that, I've opened a new PR earlier today in the SDK repo that will get us closer opsmill/infrahub-sdk-python#80
| # locust = "^2.20.1" | ||
| # docker = "^7.0.0" | ||
| # matplotlib = "^3.8" | ||
| # pandas = "^2.2" |
There was a problem hiding this comment.
Should we remove this instead?
There was a problem hiding this comment.
I would like it keep it for now because we need to fix the scale tests altogether
dgarros
force-pushed
the
dga-20241014-fix-4234
branch
from
2bee55e
to
10a7e5d
Compare
dgarros
force-pushed
the
dga-20241014-fix-4234
branch
from
10a7e5d
to
7598cd5
Compare
github-actions
bot
added
the
type/documentation
Fixes #4234
This PR integrates the Python SDK directly into the main python project for Infrahub.
The end goal is to be able to publish
infrahub-serverto Pypi in order to use it to build integration tests for any projects depending on Infrahub.Not sure what happened in CI but the changes in this PR highlighted some issues with how we are configuring poetry in our own runner.