Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resource manager documentation #4609

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Update resource manager documentation #4609

wants to merge 6 commits into from
+289 −27

Conversation

BaptisteGi
Copy link
Contributor

@BaptisteGi BaptisteGi commented Oct 11, 2024 •
edited
Loading

  • Add number pool to the documentation
  • Refactor resource manager page to create section for each type of pool
  • Various changes and improvements

@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Oct 11, 2024
@BaptisteGi BaptisteGi self-assigned this Oct 17, 2024
@BaptisteGi BaptisteGi requested a review from a team October 17, 2024 16:30
@BaptisteGi BaptisteGi marked this pull request as ready for review October 17, 2024 16:32
@BaptisteGi
Copy link
Contributor Author

fyi @fatih-acar just changed the documentation here but I see that it triggers the e2e tests, is it intended that way?

@BaptisteGi
Copy link
Contributor Author

fyi @fatih-acar just changed the documentation here but I see that it triggers the e2e tests, is it intended that way?

aaah for screenshots right?

@fatih-acar
Copy link
Contributor

fatih-acar commented Oct 18, 2024 •
edited
Loading

fyi @fatih-acar just changed the documentation here but I see that it triggers the e2e tests, is it intended that way?

aaah for screenshots right?

We use the E2E tests to generate screenshots, but not through the CI as far as I remember... we run them locally for screenshots.
I think we can disable running the E2E tests for documentation changes, you are right
cc @wartraxx51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeArchiTek BeArchiTek BeArchiTek approved these changes

Assignees

@BaptisteGi BaptisteGi

Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BaptisteGi @fatih-acar @BeArchiTek