IFC-761 Use flags to handle branch permissions #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
ogenstad
reviewed
Oct 11, 2024
CodSpeed Performance ReportMerging #4601 will improve performances by 16.35%Comparing Summary
Benchmarks breakdown
|
gmazoyer
force-pushed
the
gma-20241010-ifc761
branch
7 times, most recently
from
d6f2bd4
to
b7030e2
Compare
gmazoyer
force-pushed
the
gma-20241010-ifc761
branch
2 times, most recently
from
27fa034
to
c6f6c7b
Compare
ogenstad
approved these changes
Oct 15, 2024
| # What do we do if edit default branch global permission is set? | ||
| # if not restrict_changes: | ||
| # for key in permission_report: | ||
| # permission_report[key] |= PermissionDecisionFlag.ALLOW_DEFAULT |
There was a problem hiding this comment.
Can it be an argument to get_permission_report()?
For some reasons the issues on appear when we run tests in a row: * backend/tests/unit/graphql/test_mutation_create.py::test_create_object_with_node_property * backend/tests/unit/graphql/test_mutation_create.py::test_create_object_with_single_relationship_node_property * backend/tests/unit/graphql/test_mutation_create.py::test_create_object_with_multiple_relationships_with_node_property We should find a better fix for this.
gmazoyer
force-pushed
the
gma-20241010-ifc761
branch
from
d94284a
to
5b9fd80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.