-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic selector fixes to correctly reset values when changing kind or object #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa-lem
added
type/bug
Something isn't working as expected
group/frontend
Issue related to the frontend (React)
labels
Jul 15, 2024
github-actions
bot
added
type/documentation
Improvements or additions to documentation
group/backend
Issue related to the backend (API Server, Git Agent)
group/python-sdk
group/sync-engine
Issue related to the Synchronization engine
group/ci
Issue related to the CI pipeline
labels
Jul 15, 2024
github-actions
bot
removed
type/documentation
Improvements or additions to documentation
group/backend
Issue related to the backend (API Server, Git Agent)
group/python-sdk
group/sync-engine
Issue related to the Synchronization engine
group/ci
Issue related to the CI pipeline
labels
Jul 15, 2024
github-actions
bot
added
the
type/documentation
Improvements or additions to documentation
label
Jul 15, 2024
* add test id for close button * close alert before moving on * fix all alerts to use taost props * update test to wait after each profile creation * remove alert in console * wait for interface to be ready * correctly wait before query creation * fix check after comment creation * update verifiactions tests + increase timeout for proposed changes * increase timeout for proposed change * update objects in test to avoid concurrent testing on the same objects * update locators for hover
bilalabbad
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
group/frontend
Issue related to the frontend (React)
type/bug
Something isn't working as expected
type/documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Notes