Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic selector fixes to correctly reset values when changing kind or object #3837

Merged
merged 16 commits into from
Jul 18, 2024

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Jul 15, 2024

@pa-lem pa-lem added type/bug Something isn't working as expected group/frontend Issue related to the frontend (React) labels Jul 15, 2024
@pa-lem pa-lem requested a review from bilalabbad July 15, 2024 08:18
@github-actions github-actions bot added type/documentation Improvements or additions to documentation group/backend Issue related to the backend (API Server, Git Agent) group/python-sdk group/sync-engine Issue related to the Synchronization engine group/ci Issue related to the CI pipeline labels Jul 15, 2024
@github-actions github-actions bot removed type/documentation Improvements or additions to documentation group/backend Issue related to the backend (API Server, Git Agent) group/python-sdk group/sync-engine Issue related to the Synchronization engine group/ci Issue related to the CI pipeline labels Jul 15, 2024
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Jul 15, 2024
pa-lem added 10 commits July 15, 2024 10:29
* add test id for close button

* close alert before moving on

* fix all alerts to use taost props

* update test to wait after each profile creation

* remove alert in console

* wait for interface to be ready

* correctly wait before query creation

* fix check after comment creation

* update verifiactions tests + increase timeout for proposed changes

* increase timeout for proposed change

* update objects in test to avoid concurrent testing on the same objects

* update locators for hover
@pa-lem pa-lem merged commit 9d67d07 into stable Jul 18, 2024
35 checks passed
@pa-lem pa-lem deleted the ple-select-reset branch July 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants