Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Restrictions for Email Domains and Updated Email Functionality to Use Resend.io #2

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

Ashmitha-art
Copy link

@Ashmitha-art Ashmitha-art commented Jul 2, 2024

  1. Modify the validation logic to allow any email domain.
  2. Integrate Resend.io API for email services:
  3. Install necessary Resend.io API client libraries.
  4. Update configuration files to include Resend.io API keys.
  5. Modify the email sending logic to use Resend.io API endpoints.
  6. Write tests to verify email functionality works as expected with Resend.io.

Description

I allowed any email to be registered. Earlier only emails within the whitelisted colleges were allowed to register. I have enabled anyone to register as long as it's a valid email ID.

I have made use of Resend's integration with SMTP and nodemailer to send emails directly to the user to verify their accounts, resend verification emails and reset password.

Motivation and Context

Hacker Application techx#167 Backend Engineer's tasks.

How Has This Been Tested

I tried dummy email's that I had to ensure that the functionality was working as expected.
I checked mongo db to see if values were being entered correctly.
I checked my emails for password rest and verification emails.

Ran a simple npm run test to make sure the endpoint is returning a 400 on using resend's SMTP.

Screenshots

Screenshot 2024-07-01 at 8 29 41 PM Screenshot 2024-07-01 at 8 34 36 PM Screenshot 2024-07-01 at 9 54 43 PM Screenshot 2024-07-01 at 9 54 14 PM Screenshot 2024-07-01 at 9 54 27 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@gregv
Copy link

gregv commented Jul 5, 2024

Hey @Ashmitha-art - again, super challenging to review code with this many changes - some are formatting, and some are not.
image

@gregv gregv merged commit 28ce23f into opportunity-hack:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants