Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use snake case in models and enable linting #188

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

abraemer
Copy link
Contributor

@abraemer abraemer commented Jan 16, 2025

Summary of changes

  • Switched all field names of all models to snake_case adapting the rest of the codebase as necessary
  • Enable checking variable naming conventions in ruff's linter

Context and reason for change

Before the change, the linter would have flagged every field of the Opossum models as camelCase rendering it unusable. After this PR, we now have a consistent naming scheme across the codebase that is enforced by automatic tooling.

@abraemer abraemer enabled auto-merge January 16, 2025 13:41
Copy link
Member

@mstykow mstykow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@abraemer abraemer merged commit 0574759 into main Jan 16, 2025
10 checks passed
@abraemer abraemer deleted the refactor-use-snake-case-in-models branch January 16, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants