mvc/view: Ensure fields stay aligned relatively to another when headers are used in forms #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs are used in forms.
Monviech
force-pushed
the
form-dialog-alignment
branch
from
c8e0f40 to
812175b
Compare
|
I'm a bit skeptical having dealt with % width whac-a-mole code changes over the last decade :/ |
… modal-dialog and form-inline exist in the same view (e.g. dnsmasq).
…n msgzone_width is defined (e.g. in Intrusion Detection)
|
I would like the opportunity to whack the mole too :D |
Monviech
force-pushed
the
form-dialog-alignment
branch
from
9242347 to
431544b
Compare
|
Needed to force push this since I accidentally pushed something else in here that belongs to another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where introducing headers in forms will botch the alignment of fields because they all spawn their own table. Using relative sizes in the table and colgroup fixes this issue.
This also improves responsiveness of the modal.
Bonus: This also improved how form modals render on mobile devices.