Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move GetBootstrapURLsViaLeaseFile to dhcp package #442

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Aug 2, 2024

Fixes #441

Signed-off-by: Boris Glimcher [email protected]

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to the repo? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@glimchb
Copy link
Member Author

glimchb commented Aug 2, 2024

@bhoopesh369 @h0lyalg0rithm please review

@bhoopesh369
Copy link
Contributor

bhoopesh369 commented Aug 2, 2024

LGTM,
will write tests in #427

@glimchb glimchb merged commit e619226 into opiproject:main Aug 2, 2024
14 of 15 checks passed
@glimchb glimchb deleted the certs branch August 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move getBootstrapURLsViaLeaseFile from pkg/secureagent to pkg/dhcp
2 participants