Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build binaries using goreleaser #440

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

h0lyalg0rithm
Copy link
Contributor

@h0lyalg0rithm h0lyalg0rithm commented Jul 30, 2024

Proposed changes

This PR introduces the option to build 64bit binaries for x86_64 and arm64.The releases are generated when new tags are created and pushed to the repo.
I was able to simulate it on my fork https://github.com/h0lyalg0rithm/sztp/actions/runs/10165872886
I have set the go version to 1.19 instead of 1.20 or 1.21 because of the go.mod version

Refers to this issue #432

Types of changes

What types of changes does your code introduce to the repo? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@h0lyalg0rithm h0lyalg0rithm requested a review from a team as a code owner July 30, 2024 16:14
@h0lyalg0rithm
Copy link
Contributor Author

@glimchb Can you approve the workflows?

runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v5

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
cache-dependency-path: sztp-agent/go.sum

- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
- '*'

permissions:
contents: write

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 0: topLevel 'contents' permission set to 'write'
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow.
Tick the 'Restrict permissions for GITHUB_TOKEN'
Untick other options
NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead.
Click Remediation section below for further remediation help
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • small fix in commit message lower b in Build
  • consider just adding to existing release yaml workflow file

Signed-off-by: Suraj Shirvankar <[email protected]>
@h0lyalg0rithm h0lyalg0rithm requested a review from glimchb August 1, 2024 13:58
@glimchb glimchb linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@glimchb glimchb merged commit b8503d0 into opiproject:main Aug 1, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add binaries to package release (goreleaser)
2 participants