Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backend nvme classes #185

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

artek-koltun
Copy link
Contributor

No description provided.

@artek-koltun artek-koltun changed the title feat: add vackend nvme wrappers feat: add backend nvme classes Feb 9, 2024
@artek-koltun artek-koltun force-pushed the backend-nvme branch 3 times, most recently from 224a9d5 to 0a602ce Compare February 9, 2024 12:22
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 728 lines in your changes are missing coverage. Please review.

Comparison is base (36882b8) 34.92% compared to head (0a602ce) 32.34%.
Report is 3 commits behind head on main.

Files Patch % Lines
pydpu/proto/v1/frontend_nvme_pb2.py 1.87% 262 Missing ⚠️
pydpu/proto/v1/backend_nvme_pb2.py 2.48% 196 Missing ⚠️
pydpu/proto/v1/ipsec_pb2.py 4.50% 106 Missing ⚠️
pydpu/storage.py 27.58% 63 Missing ⚠️
pydpu/proto/v1/opicommon_pb2.py 7.93% 58 Missing ⚠️
pydpu/proto/v1/inventory_pb2.py 16.12% 26 Missing ⚠️
pydpu/proto/v1/ipsec_pb2_grpc.py 28.57% 10 Missing ⚠️
pydpu/ipsec.py 14.28% 6 Missing ⚠️
pydpu/proto/v1/inventory_pb2_grpc.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   34.92%   32.34%   -2.58%     
==========================================
  Files          27       28       +1     
  Lines        1947     2365     +418     
==========================================
+ Hits          680      765      +85     
- Misses       1267     1600     +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun marked this pull request as ready for review February 9, 2024 12:29
@artek-koltun artek-koltun requested a review from a team as a code owner February 9, 2024 12:29
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sandersms sandersms merged commit e3a2603 into opiproject:main Feb 13, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants