Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): precede nvme parent collections with nvme #880

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Feb 1, 2024

the used parent collection names are not consistent with ones described in API

CI requires opiproject/godpu#438 to pass

Unblocks HTTP frontend #878

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5d8b8d7) 74.89% compared to head (0f3b9a6) 74.89%.

Files Patch % Lines
pkg/utils/resource.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   74.89%   74.89%           
=======================================
  Files          40       40           
  Lines        3693     3693           
=======================================
  Hits         2766     2766           
  Misses        839      839           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artek-koltun artek-koltun merged commit c467a92 into opiproject:main Feb 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants