Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add graceful shutdown #599

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add graceful shutdown #599

wants to merge 2 commits into from

Conversation

artek-koltun
Copy link
Contributor

fixes #517

@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #599 (1841eca) into main (ef4f782) will decrease coverage by 0.85%.
Report is 33 commits behind head on main.
The diff coverage is 44.66%.

❗ Current head 1841eca differs from pull request most recent head dbad6e2. Consider uploading reports for the commit dbad6e2 to get more accurate results

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   75.31%   74.46%   -0.85%     
==========================================
  Files          40       41       +1     
  Lines        3622     3725     +103     
==========================================
+ Hits         2728     2774      +46     
- Misses        812      869      +57     
  Partials       82       82
Files Coverage Δ
pkg/utils/shutdown.go 44.66% <44.66%> (ø)

@artek-koltun artek-koltun force-pushed the feat-graceful-shutdown branch 2 times, most recently from 34c1dfa to c717377 Compare August 28, 2023 08:15
@artek-koltun artek-koltun marked this pull request as ready for review August 28, 2023 13:26
@artek-koltun artek-koltun requested a review from a team as a code owner August 28, 2023 13:26
glimchb
glimchb requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need ore time to review it, so for being slow...

@artek-koltun artek-koltun marked this pull request as draft October 5, 2023 06:42
@artek-koltun
feat: graceful bridge shutdown
7609b47 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
feat(shutdown): add panic handling
dbad6e2 
use simplified handling while waiting for
golang/go#53757

Signed-off-by: Artsiom Koltun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graceful shutdown service
2 participants
@artek-koltun @glimchb