Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat configurable virtio blk SPDK parameters #595

Conversation

artek-koltun
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #595 (e85194f) into main (325cfd9) will increase coverage by 0.04%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   75.76%   75.80%   +0.04%     
==========================================
  Files          21       21              
  Lines        3462     3497      +35     
==========================================
+ Hits         2623     2651      +28     
- Misses        773      776       +3     
- Partials       66       70       +4     
Files Changed Coverage Δ
pkg/frontend/blk.go 87.95% <66.66%> (-4.85%) ⬇️
pkg/frontend/frontend.go 100.00% <100.00%> (+30.43%) ⬆️

@artek-koltun artek-koltun force-pushed the feat-configurable-virtio-blk-spdk-parameters branch 2 times, most recently from c32d787 to e85194f Compare August 25, 2023 07:05
@artek-koltun artek-koltun marked this pull request as ready for review August 25, 2023 07:50
@artek-koltun artek-koltun requested a review from a team as a code owner August 25, 2023 07:50
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
this change is needed to reduce opi-intel-bridge code and reuse as much as possible
the alternative would be to re-implement blk.go functions instead of just replacing the params sent to json...

@glimchb glimchb merged commit 166c2bf into opiproject:main Aug 28, 2023
18 of 19 checks passed
@artek-koltun artek-koltun deleted the feat-configurable-virtio-blk-spdk-parameters branch November 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants