Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use copies of global test objects #591

Merged
merged 9 commits into from
Aug 29, 2023
Merged

Use copies of global test objects #591

merged 9 commits into from
Aug 29, 2023

Conversation

artek-koltun
Copy link
Contributor

see #443

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #591 (cf8fad4) into main (325cfd9) will increase coverage by 0.12%.
Report is 9 commits behind head on main.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   75.76%   75.89%   +0.12%     
==========================================
  Files          21       21              
  Lines        3462     3509      +47     
==========================================
+ Hits         2623     2663      +40     
- Misses        773      776       +3     
- Partials       66       70       +4
Files Changed Coverage Δ
pkg/frontend/blk.go 87.95% <66.66%> (-4.85%) ⬇️
pkg/frontend/frontend.go 100.00% <100.00%> (+30.43%) ⬆️
pkg/server/utils.go 19.82% <100.00%> (+9.25%) ⬆️

@artek-koltun artek-koltun force-pushed the test-use-copies-in-frontend branch 2 times, most recently from 3dbbbbd to 316acf7 Compare August 18, 2023 10:15
glimchb
glimchb approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it

@artek-koltun artek-koltun force-pushed the test-use-copies-in-frontend branch 2 times, most recently from 3e7c1a0 to cf8fad4 Compare August 29, 2023 08:47
@artek-koltun artek-koltun marked this pull request as ready for review August 29, 2023 08:50
@artek-koltun artek-koltun requested a review from a team as a code owner August 29, 2023 08:50
@artek-koltun
test(frontend): prevent global test objects modification
5d3a517 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(middleend): prevent global test objects modification
f2902cd 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(backend): prevent global test objects modification
fb6978c 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test: add function to check if global test object changed
c9cfef7 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(frontend): check if global test object changed
e73ddfa 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(middleend): check if global test object changed
70cb69d 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(backend): check if global test object changed
e3f14dd 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test(kvm): check if global test object changed
e25f9bf 
Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun
test: separate test objs copy from test setup
cf8fad4 
Signed-off-by: Artsiom Koltun <[email protected]>
@glimchb glimchb merged commit abe9076 into opiproject:main Aug 29, 2023
19 checks passed
@artek-koltun artek-koltun mentioned this pull request Aug 30, 2023
Closed
@artek-koltun artek-koltun deleted the test-use-copies-in-frontend branch November 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb