refactor(storage): rename volume_id -> volume_name_ref #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 75.48% 75.58% +0.09%
==========================================
Files 21 21
Lines 3419 3416 -3
==========================================
+ Hits 2581 2582 +1
+ Misses 771 768 -3
+ Partials 67 66 -1
|
|
depends on opiproject/godpu#252 |
glimchb
changed the title
Signed-off-by: Boris Glimcher <[email protected]>
glimchb
commented
Aug 3, 2023
| @@ -249,9 +249,6 @@ func (s *Server) verifyQosVolume(volume *pb.QosVolume) error { | |||
| if err := resourcename.Validate(volume.Name); err != nil { | |||
| return err | |||
| } | |||
| if volume.VolumeId == nil || volume.VolumeId.Value == "" { | |||
| return fmt.Errorf("volume_id cannot be empty") | |||
| } | |||
|
|
|||
| if volume.MinLimit != nil { | |||
There was a problem hiding this comment.
@artek-koltun please note this removal. I think fieldbehavior.ValidateRequiredFields covers empty string
glimchb
added
the
Merge Candidate
artek-koltun
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boris Glimcher [email protected]