Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformly check returned error on OK response in kvm #522

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Uniformly check returned error on OK response in kvm #522

merged 2 commits into from
Jul 6, 2023

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Jul 6, 2023 •
edited
Loading

see #501

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #522 (7da9f34) into main (86f91ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   70.75%   70.75%           
=======================================
  Files          21       21           
  Lines        3406     3406           
=======================================
  Hits         2410     2410           
  Misses        891      891           
  Partials      105      105

@artek-koltun artek-koltun marked this pull request as ready for review July 6, 2023 08:19
@artek-koltun artek-koltun requested a review from a team as a code owner July 6, 2023 08:19
@artek-koltun artek-koltun changed the title Uniformly check error on OK response in kvm Uniformly check returned error on OK response in kvm Jul 6, 2023
glimchb
glimchb approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@glimchb glimchb merged commit f2eca14 into opiproject:main Jul 6, 2023
15 checks passed
@artek-koltun artek-koltun mentioned this pull request Jul 7, 2023
Closed
@artek-koltun artek-koltun deleted the feat-uniformly-check-error-on-ok-response-kvm branch November 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb