Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] Rename NVMf -> Nvme #519

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Jul 5, 2023

Naming NVMf caused proto to force "nv_mf" syntax which is weird.
Unify the naming to Nvme format utilized throughout all API components.

Signed-off-by: Boris Glimcher [email protected]

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #519 (5157df8) into main (1c9d83b) will not change coverage.
The diff coverage is 81.70%.

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   70.75%   70.75%           
=======================================
  Files          21       21           
  Lines        3406     3406           
=======================================
  Hits         2410     2410           
  Misses        891      891           
  Partials      105      105           
Impacted Files Coverage Δ
pkg/backend/nvme_path.go 58.46% <75.47%> (ø)
pkg/backend/nvme_controller.go 73.72% <92.59%> (ø)
pkg/backend/backend.go 100.00% <100.00%> (ø)

Naming NVMf caused proto to force "nv_mf" syntax which is weird.
Unify the naming to Nvme format utilized throughout all API components.

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb marked this pull request as ready for review July 5, 2023 17:09
@glimchb glimchb requested a review from a team as a code owner July 5, 2023 17:09
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Jul 5, 2023
@artek-koltun artek-koltun merged commit 86f91ce into opiproject:main Jul 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants