Uniformly check returned error on OK response in middleend #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek-koltun
force-pushed
the
feat-uniformly-check-error-on-ok-response-middleend
branch
from
dd3866e
to
7322fc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 70.69% 70.69%
=======================================
Files 21 21
Lines 3399 3399
=======================================
Hits 2403 2403
Misses 891 891
Partials 105 105 |
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
glimchb
approved these changes
Jul 5, 2023
| "volume-test", | ||
| nil, | ||
| []string{`{"id":%d,"error":{"code":0,"message":""},"result":[]}`}, | ||
| codes.InvalidArgument, | ||
| fmt.Sprintf("Could not find any namespaces for NQN: %v", "nqn.2022-09.io.spdk:opi3"), |
artek-koltun
deleted the
feat-uniformly-check-error-on-ok-response-middleend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #501